-
Notifications
You must be signed in to change notification settings - Fork 0
Fix UI polish review feedback: accessibility, consistency, and UX improvements #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
…olidate shimmer Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses UI polish review feedback from PR #7, focusing on accessibility improvements, button component consistency, UX refinements, code quality, and branding alignment. The changes enhance the user experience by adding proper ARIA labels, supporting reduced motion preferences, fixing misleading interactions, and consolidating duplicate CSS.
Changes:
- Added accessibility features including aria-labels for topic chips and prefers-reduced-motion support for animations
- Fixed button component gradient animation inconsistencies in danger/success variants
- Improved UX by opening YouTube searches in new tabs instead of setting invalid URLs, removing non-functional play button, and fixing navigation arrow hover behavior
- Cleaned up unused CSS classes and consolidated duplicate shimmer animations
- Standardized branding from "Video2Learn" to "UVAI.io" throughout the application
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/components/ui/SuggestedPrompts.tsx | Added aria-label and prefers-reduced-motion support to topic chips and animations |
| apps/web/src/components/ui/Button.tsx | Added missing gradient animation hover states to danger and success button variants |
| apps/web/src/app/page.tsx | Fixed suggested topics to open YouTube search in new tab, added preview label, fixed navigation arrow group behavior, updated branding to UVAI.io |
| apps/web/src/app/globals.css | Removed unused CSS classes (input-glow, chip, text-shadow utilities) and added prefers-reduced-motion support for skeleton loading |
|
Closing: stale PR with merge conflicts or no longer relevant. Cleaned up during PR housekeeping. |
Addresses review comments from PR #7 covering accessibility gaps, animation inconsistencies, misleading UX elements, and branding conflicts.
Accessibility
aria-labelto topic chips:aria-label="Search for ${topic.label} videos"prefers-reduced-motionsupport:motion-reduce:animate-none motion-reduce:opacity-100Button Component Consistency
hover:bg-[position:100%_0]to match primary button behaviorUX Fixes
groupclass to button for propergroup-hover:translate-x-1behaviorCode Quality
shimmeranimations (skeleton now uses shared keyframe).input-glow,.chip,.text-shadow-lg,.text-shadow-glowBranding
layout.tsxmetadata, dashboard, and playground💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.